react-native-url-polyfill icon indicating copy to clipboard operation
react-native-url-polyfill copied to clipboard

Published 20 hours ago • verified publisher icon charpeni

Use globalThis instead of global in auto.js

Open staltz opened this issue 3 years ago • 1 comments

I was using auto just like the Option 1 in the readme said, and it wasn't working. Then I finally did what this comment said, and it worked. So maybe we should use globalThis instead of global.

Disclaimer: I have edited the code directly in GitHub and I haven't tested this code change. Consider this PR as a light suggestion, I don't mind if you close it.

staltz avatar Mar 03 '22 11:03 staltz

Thanks for sending this! This is also related to https://github.com/charpeni/react-native-url-polyfill/issues/366.

I'll test this.

charpeni avatar Apr 12 '22 21:04 charpeni

After one year has passed, gentle reminder this is still relevant. :)

staltz avatar Mar 02 '23 08:03 staltz

@staltz If I remember correctly, I've refactored all of this on main but failed to release it since then. 😢

I've refactored how this works, but before releasing it, I wanted to add and update existing tests—mostly with other platforms. Then, I got stuck updating versions, and expo deprecated how to upload builds, so my CircleCI is now outdated, and then the new version is still not released a year later... The infrastructure of tests for this repository is quite tedious to maintain. 😬

Sorry about that! Until I could get time to fix tests and release a new version, I would highly suggest trying to consume main directly.

charpeni avatar Mar 03 '23 17:03 charpeni