Benjs suggested updates

Open benjfitz opened this issue 5 years ago • 2 comments

Mostly white space updates, Parameters/Returns updates, changed makeQ and makeW to have quaternion_ in front

Nov 18 '20 00:11 benjfitz

Hi @benjfitz

Your change in naming impacts the tests. You should update the tests here https://github.com/charnley/rmsd/blob/master/tests/test_quaternion.py#L59 to call the new method names.

Dec 15 '20 13:12 KPLauritzen

Hi @benjfitz

Your change in naming impacts the tests. You should update the tests here https://github.com/charnley/rmsd/blob/master/tests/test_quaternion.py#L59 to call the new method names.

Thanks @KPLauritzen, I made those changes tonight.

Dec 16 '20 03:12 benjfitz