Sam Grayson
Sam Grayson
Should `common/` be a header-only nix-package?
There are several header-only libraries we use, such as [concurrentqueue](https://github.com/cameron314/concurrentqueue) and [sqlite3pp](https://github.com/iwongu/sqlite3pp). I assume we should make these nix packages to. Does nix handle header-only packages well?
Copy relevant parts of `project-scheduling`: - [runtime/main.cpp:49](https://github.com/ILLIXR/ILLIXR/blob/91c6ff35db9fc48a6407fea2131aa35429383095/runtime/main.cpp#L49) - [runtime/frame_logger2.hpp](https://github.com/ILLIXR/ILLIXR/blob/91c6ff35db9fc48a6407fea2131aa35429383095/runtime/frame_logger2.hpp)
In general, it can be useful to run: ``` isort *.py black --line-length 90 *.py mypy --strict --ignore-missing-imports *.py ``` but we have no formalized process for this (it's not...
Let's also specify whether to use ZED's parameters in OpenVINS ([here](https://github.com/ILLIXR/open_vins/blob/issue-208-cpu-timer3/ov_msckf/src/slam2.cpp#L23)) from this module. In the long run, we would like to read these params from a file, and that...
- Step 6: Define `virtual void _p_one_iteration() override {}` - Q: "Where should I put my plugin's code?" A: "If periodically scheduled, `_p_one_iteration`. If data-driven, `sb->schedule(...)`." - `threadloop` inherits from...
- Update the `v2-latest` pointer - Explain when one should clone from `master` - Use `--single-branch --branch ${branch_name` for speed (or maybe delete old branches).
2-line change lgtm. We should think about testing monado in CI.
Given the result from Mytkowicz, I don't think it's possible to make a performance comparison based on a single run. But that of course is a philosophical question for the...