Sam Grayson
Sam Grayson
See `ILLIXR_RUN_DURATION` in `runtime/main.cpp`.
Should probably have: ``` virtual void stop() override { pipe.stop(); } // Runtime promises to call stop() before destructing. virtual ~realsense() = default; ```
I think we only want this when a new version is tagged. The documentation instructs users to check out `v2-latest`.
We should probably make the GitHub Pages deployment its own repo, or reuse the `illixr.github.io` repo. It's ugly to have disconnected branches.
Clarification: Every single test run in CI. Local tests (with a persistent disk) do not suffer this problem. We need to use [GitHub actions caching](https://docs.github.com/en/actions/guides/caching-dependencies-to-speed-up-workflows) here.
The dataset gets downloaded to `.cache`. Saving it also saves the external plugins (Kimera). We should also consider moving `.deps` into `.cache`. Same with the conda env.
Pending a plugin for [KinectFusion](https://github.com/ILLIXR/KinectFusionApp/tree/illixr-integration) and a plugin for the Xtion sensor. ZED and Realsense work, but not as well as Xtion.
I noticed the line Huzi quoted was in the build directory, but the line Qinjun wants to add is in `/usr/local/lib`. I know of at least two users who require...
Maybe it would also be good to make add a failing example to our CI (test-driven development).
I concur. This issue should remain open until we answer these questions, take their implied action, and catch this class of errors in CI. But who should we assign it...