vhs icon indicating copy to clipboard operation
vhs copied to clipboard

feat: support named themes

Open caarlos0 opened this issue 1 year ago • 5 comments

Initial implementation, let me know what you think!

closes #78 refs https://github.com/catppuccin/catppuccin/issues/1711

Thanks to:

  • @jolheiser catppuccin colors
  • @dlvhdr tokyo night theme

caarlos0 avatar Oct 28 '22 19:10 caarlos0

@caarlos0 do you have git-lfs installed?

maaslalani avatar Oct 28 '22 19:10 maaslalani

I see that the GIFs are added directly to the git repo, without uploading to git-lfs

maaslalani avatar Oct 28 '22 19:10 maaslalani

oh, I dont, will install @maaslalani

caarlos0 avatar Oct 28 '22 19:10 caarlos0

@caarlos0 you might need to rebase this pr

aymanbagabas avatar Oct 28 '22 19:10 aymanbagabas

@aymanbagabas wont the squash and merge do that?

caarlos0 avatar Oct 28 '22 19:10 caarlos0

what do you think: do we add a vhs themes command, or keep it in the man page, or both?

caarlos0 avatar Oct 31 '22 01:10 caarlos0

what do you think: do we add a vhs themes command, or keep it in the man page, or both?

Maybe both? Alternatively, man pages and a markdown file?

~~As well, maybe even in a follow up, could the list be generated in go code so that vhs can verify tape files include a valid theme (if not json)?~~ Nevermind, I see it does already.

jolheiser avatar Oct 31 '22 01:10 jolheiser

Maybe both? Alternatively, man pages and a markdown file?

yup, done!

caarlos0 avatar Oct 31 '22 01:10 caarlos0

Looking really good @caarlos0, thank you for this!

maaslalani avatar Oct 31 '22 02:10 maaslalani

Looking good @caarlos0, will merge this soon!

maaslalani avatar Oct 31 '22 14:10 maaslalani

Thanks so much @caarlos0, incredible work. Thanks for baring with me with the code review ❤️

maaslalani avatar Oct 31 '22 17:10 maaslalani

was very fun to work on it, thanks for reviewing & merging @maaslalani 💙

caarlos0 avatar Oct 31 '22 17:10 caarlos0