vhs icon indicating copy to clipboard operation
vhs copied to clipboard

Allow numeric filenames as output (`1.gif`)

Open DannyBen opened this issue 2 years ago • 3 comments

Using Output 1.gif in a .tape file breaks with a friendly error.

File: test.tape
  1 │ Output 1.gif
      ^^^^^^ Expected file path after output

  1 │ Output 1.gif
             ^^ Invalid command: 1.

  1 │ Output 1.gif
               ^^^ Invalid command: gif

Error: parse error

Perhaps it could be allowed? (Of course, adding an alpha character to the path works.)

DannyBen avatar Oct 28 '22 07:10 DannyBen

Hey, thanks for the issue, I think this is reasonable. We should support any legal file name, in my opinion!

maaslalani avatar Oct 28 '22 18:10 maaslalani

Just as a heads up this is valid for VHS:

Output "1.gif"

(notice the quotes)

maaslalani avatar Oct 29 '22 23:10 maaslalani

@maaslalani Have opened a PR to address this: #108

abhijit-hota avatar Nov 01 '22 07:11 abhijit-hota