huh icon indicating copy to clipboard operation
huh copied to clipboard
verified publisher icon charmbracelet

feat: multiselect add toggle multiple support

Open jatinn opened this issue 2 years ago • 1 comments

Took a shot at adding support for support toggling multiple options as mentioned in #180

Some notable changes:

  • key bindings displayed are now based on the settings of the field rather than hard-coded
  • select-all & limit are mutually exclusive
  • ignores filter commands if filterable is false (believe it's a bug but could be a breaking change for folks if they relied on filter commands without setting the Filterable(true) on the field)

jatinn avatar Apr 07 '24 18:04 jatinn

@maaslalani does this feature make sense with your product vision? If so, anything I can help with to move this forward?

jatinn avatar May 04 '24 20:05 jatinn

This looks great! I'd definitely use this and would like to see it included. I like a and c as the key bindings, but if that were a concern, I have seen others use -> right-arrow to select all and <- left-arrow to de-select all / clear all.

tdharris avatar Jun 20 '24 20:06 tdharris

@maaslalani What do you think on this? Sorry for the poke, this one would be incredibly useful for me.

tdharris avatar Jul 09 '24 21:07 tdharris

hey!

toggle select all was added to main!

gonna close this!

sorry for the delay, and thanks for the PR anyway!

caarlos0 avatar Aug 14 '24 17:08 caarlos0