gum icon indicating copy to clipboard operation
gum copied to clipboard

Consider (optionally) highlighting the current line in gum filter

Open lwbt opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Describe the solution you'd like Currently in gum filter we can identify the current line only by a prefix. While it looks clean and while we can customize the prefix, it should be considered (to offer) to highlight the entire line to make it more clear where the user's cursor currently is. One of the simpler solutions I used in my shell scripts before was to invert/swap background and foreground colors.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context I was able to write some nice and simple things with gum filter. Like just picking a song or album from my music folder. Using this on a Steam Deck (just with the terminal from the dashboard) or a beamer is still comfortable for me, but compared to the file picker in gum (which doesn't provide fuzzy matching does it?), identifying the currently selected line is not so easy with gum filter. May be the current behavior of gum filter allows me to do things which were not intended. It's a lot of data on a small screen or a very large but comparably low resolution screen. Just changing the prefix doesn't appear to be sufficient for me or the average user I think of who might benefit from gum in shell scripts instead of custom shell code.

lwbt avatar Sep 23 '23 16:09 lwbt

Hey, just to make sure I'm understanding this correctly. Are you asking that we change visual feedback for the gum filter command so the "•" isn't the only feedback to show which line is currently focused?

bashbunni avatar Oct 31 '23 23:10 bashbunni

Hey, just to make sure I'm understanding this correctly. Are you asking that we change visual feedback for the gum filter command so the "•" isn't the only feedback to show which line is currently focused? I do understand the request so and would like to have it also. You you provide an option to set e.g. fore-/backgroud color for currently selected line when using filter.

Thanks

spachner

spachner avatar Nov 13 '23 08:11 spachner

@spachner is right. Sorry for replying so late.

lwbt avatar Nov 13 '23 16:11 lwbt