bubbletea icon indicating copy to clipboard operation
bubbletea copied to clipboard

bubbletea does not render special characters properly

Open louisescher opened this issue 1 year ago • 2 comments

Describe the bug When using, for example, German "Umlaute" (ä, ü, ö), bubbletea does not render the characters at all. Another German-specific character, ß, renders as á instead. This does not seem to be a problem with the font, as I can use the letters when writing out commands.

Setup Please complete the following information along with version numbers, if applicable.

  • OS: Windows
  • Shell: Windows Terminal/cmd

To Reproduce Steps to reproduce the behavior:

  1. Create a bubbletea application with a textinput
  2. Try to type any of the letters into the textinput
  3. See the characters not being typed/rendered

Source Code The textinput code example can be used to replicate this behaviour.

Expected behavior The special characters should render, however, they do not.

Screenshots Here is an example of what happens when typing in the ß character: image To confirm, here you can see how my terminal renders the characters with the same font & settings: image

louisescher avatar Jan 21 '24 16:01 louisescher

Okay cool, this seems to be an issue on Windows in particular (and possibly a regression).

There’s a duplicate issue at https://github.com/charmbracelet/bubbles/issues/460, however I think this repo is the appropriate place for this.

meowgorithm avatar Jan 22 '24 14:01 meowgorithm

Alright, so I'm able to reproduce this on Windows and it's indeed it's specific to Bubble Tea. We'll investigate accordingly. International support is important to us.

meowgorithm avatar Jan 22 '24 15:01 meowgorithm

Okey-dokey, this is now fixed on master via #878 and will be available in the next release. Cheers!

meowgorithm avatar Feb 27 '24 21:02 meowgorithm

Amazing, thanks for all the hard work. Should I close this now or wait for the release to come out?

louisescher avatar Feb 27 '24 21:02 louisescher

All the credit here belongs to @aymanbagabas and @erikgeiser 🙂

If you don't mind let's close this out.

meowgorithm avatar Feb 27 '24 22:02 meowgorithm

Much love to you two then! Thanks again, marking this as closed.

louisescher avatar Feb 27 '24 22:02 louisescher