charmbracelet
Fix key bindings for urxvt, add home/end combinations
Let's make sure we verify this one very carefully, including in both urxvt and otherwise.
All right I think there are two different changes here. I will split the PR which will simplify.
Ready for another look - I have split up the PR into bite-sized commits, so that they become easier to review individually.
@knz Help me understand why the last commit improves troubleshootability? I find the function keys a bit all over the place still.
Edit: Just to clarify, I'm happy with the change, I'm just wondering if I'm missing something obvious.
why the last commit improves troubleshootability?
As I was cross-checking the codes for the function keys with the source code of all the terminal emulators listed in the termenv docs, I was doing them in order of function key (starting at F1, then F2, etc). It was super hard to do because they were not in function key order in key.go. That's why I rearranged them. But feel free to drop that latest commit if you believe it's not worth the hassle.