bubbletea icon indicating copy to clipboard operation
bubbletea copied to clipboard

Ensure rendering before exec

Open raphaelvigee opened this issue 7 months ago • 4 comments

Describe your changes

I'm building an application that has a pretty strict requirement that the view has been rendered before diving into exec

Checklist before requesting a review

  • [x] I have read CONTRIBUTING.md
  • [x] I have performed a self-review of my code

raphaelvigee avatar May 29 '25 08:05 raphaelvigee

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.02%. Comparing base (e24d6b2) to head (38d0d51). Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1429      +/-   ##
==========================================
- Coverage   70.10%   70.02%   -0.08%     
==========================================
  Files          17       17              
  Lines        1726     1735       +9     
==========================================
+ Hits         1210     1215       +5     
- Misses        469      472       +3     
- Partials       47       48       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 29 '25 08:05 codecov[bot]

@aymanbagabas @meowgorithm Whats the path towards getting that merged ?

raphaelvigee avatar Sep 13 '25 10:09 raphaelvigee

Hi @raphaelvigee, could you provide an example of how would this look like and some test cases?

aymanbagabas avatar Sep 15 '25 16:09 aymanbagabas

It doesnt change anything functionally, and i dont really know what to test for, its just that in the current implementation, because the renderer is ticker based, bubbletea could enter the exec mode before the UI had time to enter "exec mode" (in my case clearing the screen), this ensure the renderering is consistent with the expected state

raphaelvigee avatar Sep 15 '25 17:09 raphaelvigee