bubbles icon indicating copy to clipboard operation
bubbles copied to clipboard

Published 20 hours ago • verified publisher icon charmbracelet

refactor: KeyMsg -> KeyPressMsg

Open bashbunni opened this issue 1 year ago • 2 comments

Cherry picked a single commit with changes from alpha branch with latest master

bashbunni avatar Aug 22 '24 18:08 bashbunni

Looking into why the test is failing

bashbunni avatar Aug 22 '24 18:08 bashbunni

Tests aren't passing on this branch - terminal color codes don't work. Need to fix that before it's ready :)

bashbunni avatar Aug 23 '24 15:08 bashbunni

@aymanbagabas do you have any thoughts on the colour issue? It seems the v2-exp lipgloss branch loses support for ansi colour codes as you can see when you run the tests on this branch. It doesn't handle ints like it used to for lipgloss.Color

bashbunni avatar Aug 26 '24 18:08 bashbunni

on Bubble Tea v2-exp it's now KeyPressMsg.Code not KeyPressMsg.Runes. Need to update that here before merging

bashbunni avatar Sep 06 '24 21:09 bashbunni

swapping out []rune with rune in bubbles is also needed based on bubble tea's v2-exp branch

bashbunni avatar Sep 06 '24 21:09 bashbunni

fwiw, i've pushed these changes to v2-exp

aymanbagabas avatar Sep 09 '24 20:09 aymanbagabas

@aymanbagabas kk sounds good! I'll close this PR then

bashbunni avatar Sep 10 '24 17:09 bashbunni