bubbles icon indicating copy to clipboard operation
bubbles copied to clipboard

Dual pane model

Open squrki opened this issue 2 years ago • 3 comments

Adds dualPane functionality as discussed. Please see demo below:

dualPane

cc: @maaslalani @taigrr @bashbunni

squrki avatar May 30 '23 18:05 squrki

@squrki can you rerun your tests with the merged-in funcs added by @meowgorithm ?

taigrr avatar Jun 01 '23 05:06 taigrr

@squrki can you rerun your tests with the merged-in funcs added by @meowgorithm ?

I confirm that it works the same as before.

squrki avatar Jun 01 '23 19:06 squrki

Hi @maaslalani,

I did some code cleanup, and now the linter is failing for some reason. The code works otherwise, so it's ready for review.

TIA.

squrki avatar Jun 02 '23 16:06 squrki

Hey, thank you so much for this, and sorry for the delay! We're leaning towards not merging this due to the maintenance cost. It also adds rigidity in a case where it would likely be sufficient to provide guidance, yet allow the users to decide on the implementation themselves. We're a small team, so we have to be very careful about what abstractions we want to officially support.

If you wanted to make the bubble available to others, you can put it in your own repo and we would be happy to feature it in the additional bubbles section. Just create a PR with a link to your repo in that section of the README :)

bashbunni avatar Mar 13 '24 21:03 bashbunni