bubbles icon indicating copy to clipboard operation
bubbles copied to clipboard

Feature request: Tree model

Open mariusor opened this issue 2 years ago • 7 comments

Hello, I want to ask if the charmbracelet community would be interested in accepting a PR for adding a tree model to the project.

A while ago I needed one for a project of mine and at the time there was none available, so I created one.

Currently I think it reached a level of maturity that other people might be interested in using it.

If anyone can have a look at the code, and the example, let me know if it would be accepted as a PR.

mariusor avatar Sep 09 '22 07:09 mariusor

@maaslalani @meowgorithm (apologies for pinging you directly, but I saw you are members of Charm that are active in the issues section).

Is there an interest in my proposal, or should I just keep it as an out of tree model?

mariusor avatar Sep 22 '22 08:09 mariusor

@mariusor Apologies for not having responded sooner, but we'll definitely check out your code! A tree-view bubble is probably inevitable and we definitely see a need for such a component. It's certainly one of the most complex visual components and getting it right is non-trivial, so I'm excited to see what you came up with!

muesli avatar Oct 05 '22 02:10 muesli

Thank you @muesli. Looking forward to comments.

mariusor avatar Oct 06 '22 10:10 mariusor

Hello everyone, any hope to review my tree model?

I have made some improvements that extend the use to something like a threaded "conversation" model, which has another example

screenshot-20231120125447_560268653-swaygrab

mariusor avatar Nov 20 '23 12:11 mariusor

Look awesome!

simbafs avatar Nov 20 '23 12:11 simbafs