bubbles icon indicating copy to clipboard operation
bubbles copied to clipboard

feat(textarea/textinput): support overwrite mode

Open knz opened this issue 3 years ago • 5 comments

For use with https://github.com/charmbracelet/bubbletea/pull/418.

cc @muesli @maaslalani

knz avatar Aug 25 '22 16:08 knz

@knz Mind rebasing this for us?

muesli avatar Oct 06 '22 11:10 muesli

Done, but note that for this to build properly it needs a release of bubbletea that contains https://github.com/charmbracelet/bubbletea/pull/418

Otherwise, I'd need to update the textinput bubble to use key.Binding (which is what textarea does already). I know we've talked with @maaslalani about this but I don't have a PR for it yet.

knz avatar Oct 06 '22 19:10 knz

Alternatively I can rebase this on top of #270 so it does not need a go.mod update immediately. WDYT?

knz avatar Oct 07 '22 12:10 knz

Ok, done. This is now ready.

knz avatar Oct 07 '22 16:10 knz

@maaslalani anything else you'd like to happen here?

knz avatar Nov 06 '22 12:11 knz

Hey! I think this might make sense in a perhaps opt-in setting for the textarea.

We also have vim-mode support (potentially):

  • #207

So, I think we might be able to make these, either opt-in, or part of a separate (more fully-featured textarea).

I will close this for now since I'm cleaning up some old PRs, but feel free to reopen as I think it does make sense in the future.

maaslalani avatar Jun 18 '24 16:06 maaslalani