impressionist icon indicating copy to clipboard operation
impressionist copied to clipboard

Support for rails 7?

Open simonsapiel opened this issue 3 years ago • 1 comments

Is there any plans to support rails 7? The gem is currently preventing me from upgrading my rails 6.1 app to rails 7 as it breaks down (https://github.com/charlotte-ruby/impressionist/issues/302) with rails 7.

simonsapiel avatar Apr 27 '22 14:04 simonsapiel

Hey, the problem is that in Rails 7 you cannot autoload reloadable code so early.

Also, it does not make sense that ImpressionistController::ClassMethods and ImpressionistController::InstanceMethods live in a reloadable file, because changes in that code won't be reflected in ActionController::Base, which is decorated only once during boot.

Would it make sense to extract those two decorators to lib and require them normally?

fxn avatar May 16 '22 23:05 fxn