impressionist icon indicating copy to clipboard operation
impressionist copied to clipboard

Rails 6.0.0 Deprecation warnings

Open jhofstede opened this issue 5 years ago • 7 comments

Just added impressionist to my Rails 6.0 (ruby 2.6.3) project found two deprecation warnings:

DEPRECATION WARNING: Initialization autoloaded the constant ImpressionistController.

Being able to do this is deprecated. Autoloading during initialization is going
to be an error condition in future versions of Rails.

Reloading does not reboot the application, and therefore code executed during
initialization does not run again. So, if you reload ImpressionistController, for example,
the expected changes won't be reflected in that stale Module object.

`config.autoloader` is set to `classic`. This autoloaded constant would have been unloaded if `config.autoloader` had been set to `:zeitwerk`.

Please, check the "Autoloading and Reloading Constants" guide for solutions.

And another one here

DEPRECATION WARNING: ActionDispatch::Http::ParameterFilter is deprecated and will be removed from Rails 6.1. Use ActiveSupport::ParameterFilter instead. (called from associative_create_statement at /Users/Julien/.rbenv/versions/2.6.3/lib/ruby/gems/2.6.0/gems/impressionist-1.6.1/app/controllers/impressionist_controller.rb:54)

jhofstede avatar Sep 17 '19 06:09 jhofstede

Me too. Already thinking about remove impressionist from my project :/

shayani avatar Oct 05 '19 09:10 shayani

Is this project abandoned?

t56k avatar Oct 10 '19 23:10 t56k

@cd-rum Not completely abandoned, but not actively maintained by anyone at this point. If anyone has a fix for this I’ll gladly merge a PR and push a new version so it’s rails 6 compatible. Also if anyone is interested in maintaining let me know and I’ll give you access.

johnmcaliley avatar Oct 10 '19 23:10 johnmcaliley

@johnmcaliley Thanks for the quick response, I'll consider it—I'm not sure my project actually requires it any longer is all, but that's a separate discussion obvs

t56k avatar Oct 11 '19 01:10 t56k

Rails 6.0.2.1 has breaking changes, so don't upgrade until the impressionist is fixed.

vadim-zverugo avatar Dec 24 '19 14:12 vadim-zverugo

Correct, locked in 6.0.2.

ianzitow avatar Jan 02 '20 17:01 ianzitow

I am getting this error when running any rspec command, in my case one workaround could be disabling class caching:

# config/environments/test.rb

Rails.application.configure do
  ...
  config.cache_classes = false
end

juanpabloxk avatar Apr 21 '23 22:04 juanpabloxk