Charlie Marsh

Results 3056 comments of Charlie Marsh
trafficstars

Should look into how Pants does this. It's a powerful basis for extending ruff (e.g., ruff could evolve into a test runner, and only test changed files or files whose...

I _definitely_ want to look into LibCST! The AST is more complicated so I have to rewrite the traversal code, but that's mostly mechanical. It may be the case that...

(Very flattering that you even care to comment here. You've contributed to some of my favorite tools. Appreciate the engagement! Same for you @jack1142!)

I'm tracking the exploration in #89. That branch implements F634 (the ~simplest AST-based lint check) using LibCST. It _is_ much slower than the current version, but I'd still like to...

I'm still interested in using LibCST to power autofixing specifically: find errors + erroring statements via the current strategy, then pass snippets to LibCST to correct.

We're now using LibCST to power some of the autofix behavior 🚀 🚀 🚀

Thanks, that's a legitimate bug, will fix :)

FTR, I initially tried to vendor my fork within ruff (then set the `path` in Cargo.toml) but that's _also_ unsupported by Cargo.

I tried to change `WithStatement` to parse via: ``` WithStatement: ast::Stmt = { "with" ":" => { let type_comment = None; let node = if is_async.is_some() { ast::StmtKind::AsyncWith { items,...