boats-animator icon indicating copy to clipboard operation
boats-animator copied to clipboard

Import frames from folder

Open le717 opened this issue 8 years ago • 5 comments

This has a higher priority level than projects because it is the fundamental process behind projects.

Code workflow idea (these are not supposed to be checkboxes. It's more of a brain dump):

  • Scan specified folder for frames (as specified by the project file), generate file list of images
  • Loop through list, adding each one to frame array, updating curFrame value, and calling updateFrameReel()
  • Display some form of loading animation while this process takes place (I made a simple loading dots animation a while back).

le717 avatar Nov 15 '15 22:11 le717

So I've implemented the core of this issue on branch issue-85 but it does not work because the fs.readdirSync option I'm using is not supported in our old version of Node. :( It's also not the most efficient because it's fully synchronous (it really should be asynchronous). Further, updating the UI is going to be a paaaaaaaiin because of the monster that is updateFrameReel().

le717 avatar Dec 23 '18 03:12 le717

Nice stuff 😊 In 0.9.x I'm hoping to bump us from NW.js 0.26.6 to 0.35. This bumps us from Node.js 9.1 to 11.3 (on a sidenote CONTRIBUTING.md should really state the version of Node included with our current version of NW.js as the required one).

Framereel logic should really be in a separate class, perhaps this would be a good opportunity to make it less of a beast?

charlielee avatar Dec 23 '18 09:12 charlielee

I thought about going ahead and implementing it because (as you see, it's rather trivial) of the positive feedback to 0.8.0 and talk of possibly using it for THAC. That said, it is part of projects, so maybe it can wait until then.

Framereel logic should really be in a separate class, perhaps this would be a good opportunity to make it less of a beast?

Yes

le717 avatar Dec 23 '18 19:12 le717

@le717 what is the status of the issue-85 branch? 😊

charlielee avatar Jan 18 '19 18:01 charlielee

The status is nothing has changed since my comment and the code is not on usable state yet.

le717 avatar Jan 18 '19 18:01 le717