vuejs-datepicker icon indicating copy to clipboard operation
vuejs-datepicker copied to clipboard

Published 20 hours ago • verified publisher icon charliekassel

Custom parsing for dates

Open tnolli opened this issue 5 years ago • 12 comments

This is a possible fix for #597

tnolli avatar Jan 08 '19 17:01 tnolli

Coverage Status

Coverage remained the same at 100.0% when pulling 1cb26707649c6ba63ad3d6b55f2b4d1019ef10ba on tnolli:features/typed-dates-custom-parsing into 7cc1c3229d95afecbbe0ac723872b99d192599d4 on charliekassel:master.

coveralls avatar Jan 08 '19 17:01 coveralls

@SylannBin thanks for the code review; I applied your suggestions (almost entirelly, Ijust moved the default to DateInput instead of Datepicker),

tnolli avatar Jan 27 '19 10:01 tnolli

OK I just spent an hour debugging this, only to arrive at the same solution (we need a custom parsing function). Any chances this can get merged (or reasons not to)?

zzen avatar Apr 10 '19 23:04 zzen

Hello ! Also facing this problem using this lib, is it possible to merge ?

lechinoix avatar Apr 15 '19 08:04 lechinoix

This feature not only solves a bunch of potential parsing issues but it also enables new use cases out of the box, such as:

  • Triggering validation errors (which occur during the parse function).
  • Contextual date parsing. For instance in a fromDate - toDate range, I would like 1980 to be parsed as 1980/01/01 in fromDate and parsed as 1908/12/31 in toDate.

Hopefully this gets merged soon.

aesfer avatar Apr 17 '19 12:04 aesfer

First of all, thanks @charliekassel for all your work on this. It's awesome!

I think this pr could close a huge amount of issues. Just for example:

  • https://github.com/charliekassel/vuejs-datepicker/issues/486
  • https://github.com/charliekassel/vuejs-datepicker/issues/583
  • https://github.com/charliekassel/vuejs-datepicker/issues/597
  • https://github.com/charliekassel/vuejs-datepicker/issues/616
  • https://github.com/charliekassel/vuejs-datepicker/issues/636
  • https://github.com/charliekassel/vuejs-datepicker/issues/677
  • https://github.com/charliekassel/vuejs-datepicker/issues/678
  • https://github.com/charliekassel/vuejs-datepicker/issues/733
  • https://github.com/charliekassel/vuejs-datepicker/issues/767

The equivalent pr for delegating formatting dates was merged the same day it was opened! https://github.com/charliekassel/vuejs-datepicker/pull/232 This has been open for 9 months now, and the last comment was 6 months ago.

Also, I would choose this over https://github.com/charliekassel/vuejs-datepicker/pull/536 because it lets users choose how the date is parsed, rather than changing the string that get's passed to Date.parse.

I just read https://github.com/charliekassel/vuejs-datepicker/issues/679#issuecomment-463611830 and saw you haven't had time to work on this, and are considering co-maintainers, which I think is a great idea! Just wondering, is there any chance of this being merged soon?

ConorSheehan1 avatar Oct 21 '19 09:10 ConorSheehan1

Any news on this?

otaviogaiao avatar Nov 01 '19 15:11 otaviogaiao

When is this feature merged? It is urgently needed for different projects.

roeb avatar Dec 30 '19 10:12 roeb

Any updates on when/whether this PR will be merged? It blocks development in several projects at the moment, so an update would be very nice ;-) Does @tnolli have to rebase his branch first, before this can be merged?

LeonidasJP avatar Mar 03 '20 09:03 LeonidasJP

Here! also waiting for the merge!!!

soulaimanassikiou avatar May 12 '20 12:05 soulaimanassikiou

Any news?

fabio-fafle avatar May 27 '20 10:05 fabio-fafle

Is there anything that we can do to help this getting merged?

heivo avatar Jul 06 '20 08:07 heivo