Charles O'Farrell

Results 132 comments of Charles O'Farrell

@steinybot Thank you for the very offer kind offer! I've added you, @dwijnand and @eed3si9n as collaborators (I hope you don't mind), just to make sure I'm not a bottleneck...

Oh, there's also a general hedgehogqa slack organisation if anyone is interested in joining? It's mostly based around the Haskell version, but Jacob (the brains behind the whole think) lurks...

@dwestheide @steinybot @dwestheide I thought I might just put my 2c out, although given how I'm not really contributing on the project it should be taken with a massive grain...

> As I understood @charleso he was arguing for separate modules (as in build artefacts, possibly sbt sub projects?), Yep, that's all I meant. I definitely don't think we should...

@dwijnand That would definitely be useful! I already added `pick` to sbt quite a while ago. https://github.com/sbt/sbt/blob/30e4c02c9c74db093dec21b31b5f8ae30a2ef6ff/main/src/test/scala/sbt/internal/TestBuild.scala#L388-L400 ```scala def pick[A](n: Int, as: Seq[A]): Gen[Seq[A]] = { if (n >= as.length)...

The other consideration if the shrinking, it's one of those functions that the library version could possibly do a better job than what you get, but that requires a little...

Looking at it again/now, the heavy use of `flatMap` is a bit of a smell (it might not shrink well, but I'm not sure). It might be possible to generate...

I was waiting for someone to ask for this. Just to confirm, is the biggest reason related to Scala.js? I'm curious, is Scala Hedgehog working in Scala.js for you at...

> Would the approach to fixing this be changing GenT to be: case class GenT[F[_], A] That's actually what it _used_ to be :) https://github.com/hedgehogqa/scala-hedgehog/pull/70 Even though that's what the...

Amazing!!! Michael's branch looks almost like what I had in mind, but I hadn't thought about the consequences of needing stack safety now. Sigh.