Charles Cooper

Results 415 comments of Charles Cooper

not at this time, you have to write the getter manually. leaving this open since it seems like something one would generally want to have. the only issue is that,...

stylistically i would have all constants be all caps -- `MINTER_TYPE: constant(String[48]) = "MinterSetPriceV1"` i think auto-generated getters are generally A Good Thing, since they remove another avenue for the...

> Is it a set of `MyStruct` objects stored? Just one? in this example - just one. `witness()` is a keyword used like `immutable()` or `public()` - so, ex. an...

i guess one open question is, do we assign from the proof or the witness? ```vyper # only allowed if a proof is allowed in calldata; bytes are copied from...

> Tbh, both of these are pretty confusing. Should probably be something more like: > > ```vyper > foo: MyStruct = self.my_struct.validate(proof) > ``` Whoa, that's pretty slick

meeting notes: should be generic type, punt until module system is more fleshed out

meeting notes: design/spec needs more details

once we have custom parser, might be good to have separate decorators for like `@item_getter` vs `@array_getter`

meeting notes: looks ok but could be confusing as the `5` in `Array[..., 5]` has slightly differing semantics from the `5` in `DynArray[..., 5]`. kicking back decision on this to...

I like the idea of using the kwargs syntax, not so excited about default values and positional args (both increase the risk of misleading code IMO).