Charles Cooper

Results 415 comments of Charles Cooper

it is also very weird to see typechecking code in AST construction. is it possible to move these to the constant folder module?

meeting notes: approved but exact format tbd

note: as of c3e43d7b8a2e2236e236b9f23c3a8f9a96de349c, the number of TODOs has only gone up ``` (vyper) ~/vyper $ git grep TODO | wc 193 1749 16345 ```

note: `pos` was renamed to `source_pos` in dfbca3eea5118ebb7873979c2e122634b7c70c53. also the number of places where `source_pos` is added is very small, so this should be a much easier change now

also python ternaries

meeting notes: approved, use `await` keyword, wait until next "minor" release. (may reconsider the keyword in the future if actual async calls are a thing, e.g. sharded execution)

another even more exotic thought -- we could have all external fns be declared with `external def`, (and internal is the default visibility). this maps directly onto the python AsyncFunctionDef...

I think we should disallow `step` for now

the `start` and `end` args could have basically the same restrictions as `slice`, but maybe also allow negative end (so `xs[start:-1]` would be equivalent to `slice(xs, start, len(xs) - start...

another option is for interface methods to be camelCase, and local variables to be snake case