Charles Cooper

Results 607 comments of Charles Cooper

https://github.com/ethereum/py-evm/pull/2076/commits/a5f6af9010bcb15d06c44e0efbee13ee2d617bc9 fixed a hotspot in memory.write, where it was looping and writing one byte of memory at a time - the commit uses native slicing notation to batch the write....

Something like https://github.com/charles-cooper/time/commit/404f094008ce826a85dafbc5fe0b54b4b6a2c0aa. To get a sense of practicality I was able to get ghc to build (https://github.com/charles-cooper/ghc/tree/day_int32) with only one change to libraries/Cabal: ```diff diff --git a/Cabal/Distribution/Simple/SrcDist.hs b/Cabal/Distribution/Simple/SrcDist.hs index...

This could probably be moved to review or final stage. It has been implemented and stable in clients for years now.

the arguments to the modifier don't need to be string literals (since we have the variables names in the global namespace) but overall i don't see any issues with this...

also, i don't see why the protection needs to be a runtime revert - can be a compile time check. in addition, the compiler should raise (or at least warn)...

related: https://github.com/vyperlang/vyper/pull/3790 does not implement this feature, but it exports variable access data for 3rd party tools to utilize

Maybe a reasonable compromise is to defer choosing the representation by defining ``` newtype RawDay a = Day a -- a is some sort of integer ``` then make the...

i just ran into this issue after checking out the fixes from https://github.com/pytest-dev/pytest/pull/11833 (specifically i am on commit 2607fe8b4706fa701925db50f7892ddff6ed2928) the following fixture setup will result in out-of-order teardown wrt setup:...

in this case i think the issue i am having has more to do with the fact that `SETUP FIXTURE TEST 2` is happening *before* `TEARDOWN FIXTURE AUTOUSE 7`.

i think considering them as stacked may be useful, as there are cases where setup/teardown needs to be stacked. or at least there could be some way to "request" stacking.