Charles Kornoelje

Results 127 comments of Charles Kornoelje

Hey @vixalien and @feuersteiner, As far as the `canUndo`, `canRedo`, `undoDepth`, `redoDepth` functionality, since those are computed values, I don't think it is necessary to add the to main temporal...

Ah, that's good to know. I'll look into fixing this issue. Thanks!

@skrat, thank you! This is helpful. I completely forgot about this edge case, and you're right that the `pastStates` and `futureStates` are not re-rendering the comments because they are not...

I think the code needs to be updated to call the `set` function in https://github.com/charkour/zundo/blob/main/packages/zundo/src/temporal.ts inside the functions `undo`, `redo`, `clear`, and `__internal.handleUserSet`. It might be a couple of days...

Ah yes, I think you're right. So inside of those functions, `set` needs to be called while also returning a new object as you said. That would likely work, and...

I have a fix for this and can publish it later tonight!

@skrat, a fix to your bug was released in v2.0.0-beta.6 I'll leave this PR open for now since it is slightly different than the one you reported.

Might need to update tests to use React ACT: https://github.com/pmndrs/its-fine/blob/main/tests/setupTests.ts

Hey @lagroms, Right now this custom styling feature is supported for the Custom Selector. Do you need support for other selectors? Thanks

Hi @lagroms! Currently it is not possible to style the labels, but that is a great idea. Would you be willing to make a PR for this feature?