chargebee-node icon indicating copy to clipboard operation
chargebee-node copied to clipboard
verified publisher icon chargebee

Fix an issue where retried GET requests are retried without query parameters

Open ksullivan opened this issue 2 months ago • 2 comments

Description

When retryConfig.enabled = true, if a GET request is retried, it will be done without query parameters

For example, if you do chargebee.subscription.list({ "customer_id[is]": "xxx" }) and the first attempt fails, all retries will behave as if you did chargebee.subscription.list()

This can be very surprising

The bug is here: https://github.com/chargebee/chargebee-node/blob/5d368515075c13c74a62575d3d3a8f02810f8dc8/src/RequestWrapper.ts#L104

Related Issues

None

Additional Information

None

ksullivan avatar Oct 20 '25 14:10 ksullivan

Hey @cb-alish, what do you think about this one? Thanks

ksullivan avatar Oct 29 '25 09:10 ksullivan

Hi @ksullivan, sorry for the delay — I completely missed this. We’ll review it and include it in the library if it’s valid. Please give us a bit of time.

cb-alish avatar Oct 29 '25 11:10 cb-alish