ramda-adjunct icon indicating copy to clipboard operation
ramda-adjunct copied to clipboard

Increase code coverage to 100%

Open guillaumearm opened this issue 6 years ago • 1 comments

The 98% codecov badge attracted my attention and I fall on this : https://codecov.io/gh/char0n/ramda-adjunct/src/8cc269fcdf3125354aceae18c564538be72e89a5/src/fantasy-land/util.js#L22

So, I grep for it :

$ git grep typeEquals
src/fantasy-land/util.js:// typeEquals :: Monad a => String -> a -> Boolean
src/fantasy-land/util.js:export const typeEquals = curry(

typeEquals is not used, is it normal ?

guillaumearm avatar Mar 17 '18 02:03 guillaumearm

Yeah it's normal. These functions are for asserting FL monad types. The problem is that they are not tested. They are still being exported as public API. So If we cover them with tests we should be OK.

const { typeEquals } = require('ramda-adjunct/lib/fantasy-land/util');

char0n avatar Mar 19 '18 02:03 char0n