ramda-adjunct icon indicating copy to clipboard operation
ramda-adjunct copied to clipboard

feat(presence): implemented presence function

Open tauantcamargo opened this issue 4 years ago • 5 comments

Implemented presence function.

Issue: #654

tauantcamargo avatar Dec 17 '21 13:12 tauantcamargo

@char0n i'll take a look to the requests, thank u by the way.

tauantcamargo avatar Jan 02 '22 17:01 tauantcamargo

Codecov Report

Merging #2123 (1810924) into master (6c82686) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 1810924 differs from pull request most recent head 191baf5. Consider uploading reports for the commit 191baf5 to get more accurate results Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2123   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files         234      234           
  Lines         622      622           
=======================================
  Hits          612      612           
  Misses         10       10           
Flag Coverage Δ
unittests 98.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c82686...191baf5. Read the comment docs.

codecov[bot] avatar Jan 20 '22 08:01 codecov[bot]

I'm not sure I understand changes that have been made to this PR during last 3 commits. master branch now has isBlank function which is part of the public API of ramda-adjunct. We just cannot move it to internal directory anymore.

Now we should also fully utilize isBlank implementation to it's full potential:

const presence = when(isBlank, stubNull);

Notes to above implementation:

  • present is opposite of blank
  • when value is present return it, otherwise return null
  • the above sentence can also be: when value is blank return null, othersiwe return the original value (and that's our implementation)

char0n avatar Jan 23 '22 10:01 char0n

@char0n i got it .. i'll update it later ..

tauantcamargo avatar Jan 24 '22 18:01 tauantcamargo

Right, let me know if you need any assistence

char0n avatar Feb 05 '22 11:02 char0n