Vladimír Gorej

Results 588 comments of Vladimír Gorej

@gabrielsimongianotti we have only one case of using the `isEmpty` function here: https://github.com/swagger-api/swagger-js/blob/e5788a8d1233b6cbbc0821d43392393c5a6ec607/src/specmap/lib/all-of.js#L38 We're specifically asserting if the plain object is not an empty one. IMHO we can replace that...

Anybody would want to take care of `get`? Just not to loose the momentum with this issue.

There is a regression in introduced in https://github.com/swagger-api/swagger-js/commit/067229e8f7d6b55a68cb62278a662fc2a97c9f0a described in https://github.com/swagger-api/swagger-ui/issues/7771 that manifests in SwaggerUI

@srl295 would be able to rebase this PR on top of current swagger-js? Thank you!

The moment we switch to [email protected], these tests should pass, and I'll incorporate them into codebase. @srl295 thanks again!

Hi @encodeering, @hkosova is right about the validity of your definition. Though you're right that this is a possible `bug`. Here is a **POC** demonstrating when the `bug` occurs: ```js...

Yes @jimmywarting is absolutely right. We need `[email protected]` to be able to add support for data URLs. Here is a POC: ```js import fs from 'node:fs'; import util from 'node:util';...

> @char0n Would it be ok to remove to resolved externalValue and place the resolved value in the `.value` path instead. Yes, `externalValue` should stay unmodified, and the resolved thing...

> @char0n currently I am reading the OAS Spec 3.1.0, it is stating that [externalValue should follow the Relative References Section] Yes it does, but swagger-client only supports OAS 3.0.3...

@mathis-m as you mentioned the base64 requirement is missing. I'll start testing this PR against the requirements of OAS 3.0.x specification.