Vladimír Gorej
Vladimír Gorej
@mathieutu well along with typing you also changed the description of the function. If you amend the PR and return the description to original state I'll be willing to just...
On another note, what is the difference between TS Dictionary and Record? Why prefer the Dictionary? Thanks for enlightening me ;]
The change looks fine but we're not failing a typing test. More info here: https://app.circleci.com/pipelines/github/char0n/ramda-adjunct/741/workflows/ef5169e4-93c7-44f6-81b1-d58c0806c5b1/jobs/21335/parallel-runs/0/steps/0-103
@mathieutu are you willing to continue on this PR as @BenoitHiller suggested?
Can you pls demonstrate some examples on some fixtures data and explain the reason why it should return the array ? I'm trying to understand your motivation and see the...
Yeah I see the potential there. We have to be careful with the name though, `map` invokes homomorphic operation. This is more like `unzipObjectWith/unzipObjWith` transformation.
To form a partial isomorphism with `R.zipObj` the transformation needs to look like this: ```js const patient = { 'abbrev@1':{ version:'1.0.9', resolved:'https://registry.yarnpkg.com/abbrev/-/abbrev-1.0.9.tgz#91b4792588a7738c25f35dd6f63752a2f8776135' }, 'shell-quote@git+https://github.com/srghma/node-shell-quote.git#without_unlicenced_jsonify':{ version:'1.6.0', resolved:'git+https://github.com/srghma/node-shell-quote.git#0aa381896e0cd7409ead15fd444f225807a61e0a' }, '@graphile/plugin-supporter@git+https://1234user:[email protected]/git/users/1234user/postgraphile-supporter.git':{ version:'1.6.0', resolved:'git+https://1234user:[email protected]/git/users/1234user/postgraphile-supporter.git#1234commit'...
What about calling your function `objToArrayWith` with alias of `objectToArrayWith`. The function accepts a binary transformer function and an object. IMHO having a non-homomorphic function which name starts with map...
Created special issue for [unzipObjWith](https://github.com/char0n/ramda-adjunct/issues/801) as `unzipObjWith` can be implemented as specialization of `objToArrayWith`.
I'll look into this.