next-drupal icon indicating copy to clipboard operation
next-drupal copied to clipboard

feat(next): dynamic consumer paths

Open mglaman opened this issue 2 years ago • 6 comments

Provides dynamic consumer paths from generated URL using Consumer collection route.

fixes #615

This pull request is for: (mark with an "x")

  • [ ] examples/*
  • [x] modules/next
  • [ ] packages/next-drupal
  • [ ] starters/basic-starter
  • [ ] starters/graphql-starter
  • [ ] Other

GitHub Issue: #615 Please add a link to the GitHub issue where this problem is discussed.

  • [ ] I need help adding tests. (mark with an "x") Code changes need test coverage. If you don't know how to make tests, check this box to ask for help.

Describe your changes

Uses the collection route name and generates the relative URL.

mglaman avatar Dec 07 '23 21:12 mglaman

@mglaman is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 07 '23 21:12 vercel[bot]

I just noticed the failures, will fix

mglaman avatar Dec 12 '23 13:12 mglaman

Merged in main, seems like unrelated errors

mglaman avatar Dec 12 '23 19:12 mglaman

Test needs consumers added to dependencies

mglaman avatar Dec 13 '23 19:12 mglaman

From the error log:

1) Drupal\Tests\next\Kernel\Renderer\MainContent\NextSiteEntityControllerTest::testEnvironmentVariables
PHPUnit\Framework\Exception: Unavailable module: 'consumers'. If this module needs to be downloaded separately, annotate the test class with '@requires module consumers'.

JohnAlbin avatar Feb 22 '24 12:02 JohnAlbin

Ah, need to add to require-dev, which the current workflow may not do. I'll update to ensure the dependency is available during tests

mglaman avatar Feb 22 '24 19:02 mglaman