Drupal 10 compatibility fixes.

[apathak18]

While scanning the next contributed module using upgrade status we found total 6 issues in which I have resolved 5 and 1 is remaining. @internal tagged in the annotation of class won't allowed to extend. Below is the attached screenshot of remaining error.

Reference link: https://www.drupal.org/about/core/policies/core-change-policies/bc-policy#internal

[vercel[bot]]

@apathak18 is attempting to deploy a commit to the Chapter Three Team on Vercel.

A member of the Team first needs to authorize it.

[shadcn]

Thanks for the fixes. We're working on adding support for Drupal 10. I'll get back to this.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
next-drupal	✅ Ready (Inspect)	Visit Preview	Nov 29, 2022 at 9:47AM (UTC)

[apathak18]

@shadcn the dependencies of contributed modules in the composer.json & info.yml is also gonna be a blocker. drupal/decoupled_router (Needs to be compatible) ~~ https://www.drupal.org/project/decoupled_router/issues/3286939 drupal/pathauto (https://www.drupal.org/project/pathauto/releases) ~~ need to update drupal/simple_oauth (https://www.drupal.org/project/simple_oauth/releases) ~~ alpha release with D10 support. drupal/subrequests (3.0.6)

cc: @vipin-mittal-acquia

[vipin-mittal-acquia]

@shadcn : Could you please have a look and let us know if you are good to release Next.js D10 stable version.

[shadcn]

Hi everyone. Just dropping in to say thanks for all the work on this PR. I'm currently wrapping up #301. Once this is done, I'll start looking into fixing the code for Drupal 10.

[vipin-mittal-acquia]

LGTM

Hi everyone. Just dropping in to say thanks for all the work on this PR. I'm currently wrapping up #301. Once this is done, I'll start looking into fixing the code for Drupal 10.

Thanks @shadcn for response and looking forward to hear you on this #313

[vipin-mittal-acquia]

Hello @shadcn : In your opinion, what are the chances of these changes being integrated into the stable version of Drupal 10 in the near future?

[shadcn]

@vipin-mittal-acquia I'll review and we can merge it for the upcoming release 1.4.0. Planned for next week.

[vipin-mittal-acquia]

@shadcn: Are there any updates on the release of D10 stable version?

[vipin-mittal-acquia]

@vipin-mittal-acquia I'll review and we can merge it for the upcoming release 1.4.0. Planned for next week.

Hello @shadcn: The 1.4.0 version of Next is not compatible with Drupal 10. How soon will a D10 compatible release be available?

[shadcn]

@apathak18 Which phpcs config are you using? I'm not seeing the same warnings with the one here: https://github.com/chapter-three/next-drupal/blob/main/modules/next/phpcs.xml.dist

[apathak18]

Hi @shadcn, I've installed phpcs globally on my system and run locally to resolve the phpcs warnings, Below are the ruleset and args used in my local phpcs.xml.dist

<ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:noNamespaceSchemaLocation="../vendor/squizlabs/php_codesniffer/phpcs.xsd">
  <arg name="extensions" value="php,module,inc,install,test,profile,theme,css,info,txt,md,yml"/>

[shadcn]

@apathak18 I added a workflow for running the phpcs for us. Can we revert the code style changes to this PR and only fix the Drupal 10 compatibility? We can take on the code style ones in a separate PR.

[apathak18]

Hi @shadcn, I've remove the phpcs fixes commit, please check if the PR is legit to merge?

[apathak18]

Hi @shadcn , Here is my D.O username: ankitv18

[vipin-mittal-acquia]

Thanks very much @shadcn for integrating it into development. If you need time for a stable release, can we have an alpha/beta version so we can test the module and let you know if any issues arise.

[shadcn]

@vipin-mittal-acquia It's in the dev snapshot.

composer require 'drupal/next:1.0.x-dev@dev'

[vipin-mittal-acquia]

@vipin-mittal-acquia It's in the dev snapshot.

composer require 'drupal/next:1.0.x-dev@dev'

For the quick check, we'll use the development version, but for the Acquia CMS Headless release, we need the pre-release version to prevent breaking changes and it would be helpful to have it this week.

[shadcn]

@vipin-mittal-acquia Sure. I'll tag a pre-release.

[shadcn]

@vipin-mittal-acquia I tagged an alpha for now. We have one more feature we want in before the 1.5.0.

composer require 'drupal/next:^1.5@alpha'

[vipin-mittal-acquia]

@vipin-mittal-acquia I tagged an alpha for now. We have one more feature we want in before the 1.5.0.

composer require 'drupal/next:^1.5@alpha'

Thanks very much @shadcn. It would be really helpful!!