AppleNewsAPI icon indicating copy to clipboard operation
AppleNewsAPI copied to clipboard

Wrong backgroundColor validation

Open SergiuSavva opened this issue 7 years ago • 1 comments

backgroundColor - The article's background color, defined as a 3- to 8-character RGBA hexadecimal string; e.g., #000 for black or #FF00007F for red with an alpha (opacity) of 50%. Defaults to white

src/Document/Styles/DocumentStyle.php

if should be https://github.com/chapter-three/AppleNewsAPI/blob/master/src/Document/Styles/DocumentStyle.php#L67

  protected function validateBackgroundColor($value) {
    if (!$this->isHexColor($value)) {
      $this->triggerError('backgroundColor is not valid');
      return FALSE;
    }
    return TRUE;
  }

SergiuSavva avatar Aug 30 '17 12:08 SergiuSavva

What is the alternate for this issue, as removing the setDocumentStyle makes it impossible to implement DocumentStyle class to add backgroundcolor for the article.

RajeevChoudharyNBC avatar Feb 23 '22 15:02 RajeevChoudharyNBC