packages icon indicating copy to clipboard operation
packages copied to clipboard

Remove grouping from all packages

Open PedroHLC opened this issue 3 years ago • 17 comments

  • What happens?

    There are a lot of VCS packages being suggested in Xorg, Gnome, and KDE groups.

  • What is expected to happen?

    We don't want to add those to any stable group.

PedroHLC avatar Apr 04 '21 15:04 PedroHLC

So far, what I've done is add a -git suffix to the original group name (plasma-git, kde-applications-git, etc). That way, we still have groups, but there's no conflicts. We can have our cake and eat it too :)

IslandC0der avatar May 21 '21 15:05 IslandC0der

I don't recall why I didn't close this issue yet, is as simple as adding sed -i'' 's/^groups=.*$//g' PKGBUILD in https://github.com/chaotic-aur/toolbox/blob/main/src/lib/interfere.sh#interfere-generic

PedroHLC avatar May 21 '21 16:05 PedroHLC

@IslandC0der, I could remove all groups, except the ones ending in "-git", would that be good for you?

PedroHLC avatar May 21 '21 16:05 PedroHLC

@PedroHLC yeah, sounds good! Or we could add -git to every group (I wouldn't mind making that happen), whichever you think is better :)

IslandC0der avatar Jun 05 '21 00:06 IslandC0der

I need some magic "sed", capable of doing that, right now I'm just removing all groups :+1:

PedroHLC avatar Jun 13 '21 15:06 PedroHLC

@PedroHLC how about this: sed '/^groups=(/s/ /-git /g;/^groups=(/s/)/-git)/' 👀

IslandC0der avatar Jun 13 '21 15:06 IslandC0der

@PedroHLC how about this: sed '/^groups=(/s/ /-git /g;/^groups=(/s/)/-git)/' eyes

That doubles "-git" in the ones that already ends in it :smile:

PedroHLC avatar Jun 13 '21 17:06 PedroHLC

@PedroHLC there: sed '/^groups=(/s/ /-git /g;/^groups=(/s/)/-git)/;/^groups=(/s/-git-git/-git/g' 😂

IslandC0der avatar Jun 13 '21 17:06 IslandC0der

BUT WAIT, is that really desired? I think we should "Just keep the -git" ones... EDIT1: Or keep the "-git", and prefix any other with "chaotic-"... EDIT2: I wonder if that will affect garuda somehow...

PedroHLC avatar Jun 13 '21 17:06 PedroHLC

Personally, I don't think we should remove the other groups, because we're basically just removing functionality; adding the -git suffix or a chaotic- prefix would fix all the issues people were having, while still keeping the groups functionality. Between those two, I think I'd favor -git, since we try to stick as closely as possible to the AUR PKGBUILDs, and it wouldn't make sense to add chaotic- to the ones being distributed on the AUR. What do you think?

IslandC0der avatar Jun 13 '21 17:06 IslandC0der

:thinking: I think we should add "-git" only to the packages ending in "-git", otherwise, remove them all...

PedroHLC avatar Jun 13 '21 17:06 PedroHLC

Ohhh okay, I see what you mean; yeah I agree, it doesn't make sense to add non -git packages to -git groups. So is the group conflict problem also happening with non VCS packages?

IslandC0der avatar Jun 13 '21 18:06 IslandC0der

EDIT2: I wonder if that will affect garuda somehow...

We dont use groups to install packages, metapkgs are used for that purpose so it should not cause issues I guess 👀

dr460nf1r3 avatar Jun 13 '21 18:06 dr460nf1r3

So is the group conflict problem also happening with non VCS packages?

We don't keep track of them, it all started with a -bzr package: https://github.com/chaotic-aur/packages/issues/16

PedroHLC avatar Jun 13 '21 19:06 PedroHLC

Yep, definitely is a problem while installing Arch with chaotic repos enabled, best solution would be to create -git and non -git groups

maydayv7 avatar Jun 28 '21 10:06 maydayv7

Or, users can just install using pacman -S extra/package_name

maydayv7 avatar Jun 28 '21 10:06 maydayv7

I'd go with chaotic- for all packages

JuniorJPDJ avatar Aug 25 '21 23:08 JuniorJPDJ

Should this be closed yet?

nyabinary avatar Oct 14 '22 20:10 nyabinary

Yup! https://github.com/chaotic-aur/toolbox/blob/main/src/lib/interfere.sh#L84

dr460nf1r3 avatar Oct 16 '22 18:10 dr460nf1r3