chaostoolkit-lib icon indicating copy to clipboard operation
chaostoolkit-lib copied to clipboard

Validate all errors

Open dmartin35 opened this issue 4 years ago • 1 comments

@Lawouach This is the first version of global validation for the experiment syntax.

This is appending/extending a list of Exception instances along the validation line and reporting all errors at once, at the end of experiment validation (before raising a global exception that is matched & logged by the CLI)

Improvement, in this version, for each error we create an instance of a sub class of ChaosException. We might simplify to only handle a list of errors messages as strings.

To be continued, if we choose this solution, the hypothesis module still need to be updated

dmartin35 avatar Dec 26 '19 15:12 dmartin35

Codecov Report

Merging #155 into master will increase coverage by 0.42%. The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   86.41%   86.83%   +0.42%     
==========================================
  Files          23       23              
  Lines        1627     1664      +37     
==========================================
+ Hits         1406     1445      +39     
+ Misses        221      219       -2
Impacted Files Coverage Δ
chaoslib/provider/process.py 92.15% <100%> (+0.66%) :arrow_up:
chaoslib/exceptions.py 100% <100%> (ø) :arrow_up:
chaoslib/hypothesis.py 89.1% <100%> (+0.66%) :arrow_up:
chaoslib/control/python.py 87.5% <100%> (+0.29%) :arrow_up:
chaoslib/extension.py 84.9% <100%> (+0.59%) :arrow_up:
chaoslib/control/__init__.py 87.29% <40%> (+0.14%) :arrow_up:
chaoslib/activity.py 88.48% <65.21%> (+0.89%) :arrow_up:
chaoslib/provider/http.py 84.9% <85.71%> (+0.59%) :arrow_up:
chaoslib/experiment.py 91.89% <88.88%> (+0.17%) :arrow_up:
chaoslib/provider/python.py 87.17% <93.75%> (+0.87%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 44c3bf7...2cacb7b. Read the comment docs.

codecov-io avatar Dec 27 '19 11:12 codecov-io