kill_microservice not working correctly

[gilles537]

similar to #42

Code:

"type": "action",
            "name": "stop-provider-service",
            "provider": {
                "type": "python",
                "module": "chaosk8s.actions",
                "func": "kill_microservice",
                "arguments": {
                    "name": "my-provider-app"
                }

Output:

[2019-08-30 09:40:44 ERROR]   => failed: TypeError: delete_namespaced_deployment() takes 3 positional arguments but 4 were given

I got this code from the Sample github but the kill_microservice function does not seem to be working correctly.

[toranb]

@dustinfarris awesome! I'm hopeful it helps move us closer to the silver bullet while avoiding whatever it was that @dbashford ran into w/ the setProperties variation from last week. I'll wait until I hear from both of them that this is regression free/ solid before we get a v1.9.2 out the door

[dustinfarris]

the remaining "Problem Statement" back in #30 was that we call redux.getState() multiple times during re-render work and that could be expensive.

I wonder how expensive redux.getState() really is? I would guess under the hood the browser is just kicking around a pointer. I'd be more interested in knowing how expensive the stateToProps function is for a non-trivial component.

in the computed prop:

defineProperty(component, name, computed(function() {
            return finalMapStateToComputed(redux.getState())[name];

I'd bet the finalMapStateToComputed which gets run on every single property is much more expensive than the redux.getState() part.

Anyway, probably discussion best saved for another issue/PR.

[dbashford]

Looking good here!

[justinpark]

All good here too!

[Lawouach]

Thanks for the report. I'm going to have a look asap.

[Lawouach]

Indeed this is an issue because the Kubernetes client switched from all positional to some args to be key based. This was fixed in master of the extension.

I will do my best to release a new version this week.

[Lawouach]

This has now been released. Could you please try and let us know if it solved the pb?