chaostoolkit-kubernetes
chaostoolkit-kubernetes copied to clipboard
Add unavailable replicas calculation
@brettburley can't say I have a problem with this - seems to make sense. Anyone else pros/cons to making this change (aside from the find/replace for import statements when we land a v3.0.0 later this year) ?
@brettburley I went ahead and rebased this branch - it seems g2g but I wanted your final input before we roll ahead. On a related note, this made the typescript definition work much easier so that is a large reason I'm suddenly motivated to land this ;)
Yep, this still looks good to me!
@brettburley this is now published in ember-redux v2.7.0 (I also updated the guides to reflect this new import location)
Proposal for #112 issue
Hello,
Looks like a good idea. I wonder if the meaning of unavailable only means unready though? Could we find anything in the Kubernetes spec/code that clarifies this?
Indeed unavailable_replicas
is a deployment status property. May be the best is to remove this information from log
Codecov Report
Merging #113 (96d1db7) into master (4dbb88a) will increase coverage by
1.06%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #113 +/- ##
==========================================
+ Coverage 79.33% 80.40% +1.06%
==========================================
Files 14 17 +3
Lines 818 939 +121
==========================================
+ Hits 649 755 +106
- Misses 169 184 +15
Impacted Files | Coverage Δ | |
---|---|---|
chaosk8s/statefulset/probes.py | 95.12% <ø> (ø) |
|
chaosk8s/actions.py | 80.95% <0.00%> (ø) |
|
chaosk8s/probes.py | 100.00% <0.00%> (ø) |
|
chaosk8s/__init__.py | 85.13% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4dbb88a...96d1db7. Read the comment docs.