wg-metrics-development icon indicating copy to clipboard operation
wg-metrics-development copied to clipboard

Release/Revision Change_Requests_Duration.md

Open klumb opened this issue 4 years ago • 7 comments

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Change_Requests_Duration.md

GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Change_Requests_Duration.md

See all release candidates of metrics are at: https://chaoss.community/metrics/

klumb avatar Oct 26 '20 15:10 klumb

Name change revision - From "reviews to "change request"

klumb avatar Oct 26 '20 15:10 klumb

Change Request LGTM!

Signed-Off-By: Armstrong [email protected]

foundjem avatar Oct 26 '20 16:10 foundjem

Is there a reason why we would not consider PRs/MRs that are not accepted? If a change request is not accepted for valid reasons (e.g. the change would introduce a bug), I think it makes sense to include that change request if the goal of this metrics is to see how responsive reviewers are to change requests.

rpaik avatar Feb 16 '21 00:02 rpaik

@rpaik, are you suggesting that we include change requests that were not accepted? If that is the case, we may have to consider abandoned circumstances, which will make it almost impossible to compute the duration.

Signed-Off-By: Armstrong [email protected]

foundjem avatar Feb 16 '21 00:02 foundjem

@foundjem how about if we consider change requests that have either been accepted or closed? The abandoned change requests will then be excluded.

rpaik avatar Feb 16 '21 05:02 rpaik

closing for release

May want to address this last comment in the next release

klumb avatar Mar 06 '21 17:03 klumb

We need to revisit this metric. The question does not seem to match the rest of the metric definition and when looking through the above comments on this issue, we should clarify the "abandoned requests" nuance as mentioned above.

ElizabethN avatar Apr 08 '22 14:04 ElizabethN

Doing a little repo cleanup today and I'm going to close this, as we are updating all metrics to the new template and doing a refresh of them all in the process.

ElizabethN avatar Oct 14 '24 19:10 ElizabethN