grimoirelab icon indicating copy to clipboard operation
grimoirelab copied to clipboard

[docker] Add logrotate to docker

Open arnonm-intel opened this issue 4 years ago • 4 comments

Add logrotate to docker and set to keep 3 copies of /log/all.log at 100MB each

arnonm-intel avatar Mar 01 '20 14:03 arnonm-intel

Thanks a lot, @arnonm-intel. Tests are failing because of the DCO thing. Please check "DCO and Sign-off contributions" in CONTRIBUTING.md.

Now, wrt the patch itself. I like the idea of keeping logs under control, but at the same time I'm a bit reluctant to have it because of the added dependency (on logrotate). Anyone else has an opinion on this? (Any further comment by you @arnonm-intel is welcome, of course).

jgbarah avatar Mar 02 '20 08:03 jgbarah

We use the containers to run the stack for months on end. As a result, the log file continues to grow and eventually hits a limit I saw two options here – either add a rotate functionality to SirMordred, or add it to the container in the simplest way – a logrotate

From: Jesus M. Gonzalez-Barahona [email protected] Sent: Monday, March 02, 2020 10:54 To: chaoss/grimoirelab [email protected] Cc: Meshoulam, Arnon [email protected]; Mention [email protected] Subject: Re: [chaoss/grimoirelab] [docker] Add logrotate to docker (#303)

Thanks a lot, @arnonm-intelhttps://github.com/arnonm-intel. Tests are failing because of the DCO thing. Please check "DCO and Sign-off contributions" in CONTRIBUTING.mdhttps://github.com/chaoss/grimoirelab/blob/master/CONTRIBUTING.md#dco-and-sign-off-for-contributions.

Now, wrt the patch itself. I like the idea of keeping logs under control, but at the same time I'm a bit reluctant to have it because of the added dependency (on logrotate). Anyone else has an opinion on this? (Any further comment by you @arnonm-intelhttps://github.com/arnonm-intel is welcome, of course).

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/chaoss/grimoirelab/pull/303?email_source=notifications&email_token=AHOSQLHVFB5UBQY2SCPW4J3RFNX2DA5CNFSM4K7FCE62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENOOM4Y#issuecomment-593290867, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHOSQLCAI4KX4VMWKJBBA5DRFNX2DANCNFSM4K7FCE6Q.

Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.

arnonm-intel avatar Mar 03 '20 13:03 arnonm-intel

Signature fixed. Can you retrigger it?

arnonm-intel avatar Mar 04 '20 09:03 arnonm-intel

Signature fixed. Can you retrigger it?

I'm not seeing new commits with signature... Maybe you didn't push them or something?

jgbarah avatar Mar 05 '20 22:03 jgbarah