grimoirelab-tutorial icon indicating copy to clipboard operation
grimoirelab-tutorial copied to clipboard

[refactor] Location of image files and internals bug fix

Open Polaris000 opened this issue 6 years ago • 2 comments

While fixing issue #57, I had n't noticed that images were present in the assets folder. Thus, I created an images folder just to store the favicons for the site. I think it would be a great idea to move everything to one place: either to the assets folder or to the images folder.

Also, the README in the internals folder leads to the creation of this page when the site is generated. This causes a problem when users navigate away from this page, since the relative base url now ends with a /internals, leading to page not found errors.

I think the README should be deleted to fix this problem.

Polaris000 avatar May 24 '19 05:05 Polaris000

Please have a look @jgbarah, whenever covenient!

Polaris000 avatar Jun 13 '19 04:06 Polaris000

This issue is handled in the new version of the tutorial https://github.com/chaoss/grimoirelab-tutorial/pull/178

vchrombie avatar Oct 10 '21 09:10 vchrombie

I believe this PR can be closed.

cc:@sduenas

fioddor avatar Aug 31 '24 21:08 fioddor