grimoirelab-sigils icon indicating copy to clipboard operation
grimoirelab-sigils copied to clipboard

New Git Performance panel PoC

Open jsmanrique opened this issue 7 years ago • 5 comments

I have created a panel to showcase average files and lines of code changed by commit (total and evolution over time) Thanks to new gauges visualizations in Kibiter 6.x and Timeline, I've put some thresholds that allow to check if they are passed and how the trend evolves: imagen

The panel includes authors and repositories tables to make easy to filter by author and repository.

Here goes the .json file zipped: jsm_git_perfomance.zip

The panel has been exported with Kidash.

If you find it useful, feel free to add it to the default platform or modify it for your needs

jsmanrique avatar Jun 11 '18 17:06 jsmanrique

Hi there, thanks a lot for this @jsmanrique . This looks great to me.

Some comments for the next panels:

  • There's a specific naming for index patterns, visualizations or even the panels. Please in the following try to comply with those: https://github.com/chaoss/grimoirelab-sigils/blob/master/README.md
  • Said this, it's ok to work in this way as we do not overwrite previous widgets, but this will take time to us to modify your JSON doc in order to follow the expected naming.
  • It seems that you're not following or using an updated version of the Git index as your visualization is looking for a field named as lines_deleted, while the name is lines_removed: https://github.com/chaoss/grimoirelab-elk/blob/master/schema/git.csv#L22
  • How did you choose the thresholds for the average number of files and lines for the gauges? It would be good to have some references. Another point would be to let users know about this and that this is configurable, so they can have their own customized number (although having numbers is still a good idea...)

And that's all, we're working right now on this panel.

Thanks!

dicortazar avatar Jun 18 '18 07:06 dicortazar

@dicortazar are you working on this?

alpgarcia avatar Nov 22 '18 08:11 alpgarcia

I think you can close this pull request without merging the proposing changes. I don't have much time to work on this. Sad to see my contributions haven't been useful at all

jsmanrique avatar Nov 22 '18 09:11 jsmanrique

@jsmanrique now that you have your first contrib in, you may want to update this instead of closing it ;)

alpgarcia avatar Dec 13 '18 09:12 alpgarcia

Ok, I'll submit a PR. Thanks for your help and your patience

jsmanrique avatar Dec 13 '18 11:12 jsmanrique