grimoirelab-perceval icon indicating copy to clipboard operation
grimoirelab-perceval copied to clipboard

Adapted the paths to work with Microsoft Windows too.

Open shongoku opened this issue 9 years ago • 4 comments

Before the files used the symbol "" and other that this don't work with Microsoft. I've deleted this part to work with Posix and Windows systems.

shongoku avatar Oct 26 '16 17:10 shongoku

Coverage Status

Coverage decreased (-0.03%) to 84.664% when pulling ecb2a820ceb5031767c11b261cf75bb0d84c404c on shongoku:windows into e5ca777599d1d791b1e0d7ea59bb22da99b68fc7 on grimoirelab:master.

coveralls avatar Oct 26 '16 17:10 coveralls

I still think we need to find a better way to include this feature. I was thinking if we merge this patch we will have a different behaviour in Windows with the directories where the cache is stored. For instance, in Windows, a URI like https://example.org/project/repository will be stored in a directory of name example.org/project/repository while in Unix, the cache will be stored in the subdirectory repository, under project and example.org. I think we should have the same behaviour for both platforms.

sduenas avatar Nov 15 '16 09:11 sduenas

The question is if you have two operating system, why do you have the same URI? The main is the result and both are OK.

shongoku avatar Nov 15 '16 21:11 shongoku

We now have a lot of conflicts here, and I'm not sure if you @sduenas came with a better solution for this... Any idea, anyone? Having this working in Windows would be rather interesting, from my point of view.

jgbarah avatar Aug 05 '17 17:08 jgbarah

I'm going to close this PR because unfortunately, for technical reasons, GrimoireLab doesn't support Windows.

sduenas avatar Oct 13 '23 09:10 sduenas