grimoirelab-elk icon indicating copy to clipboard operation
grimoirelab-elk copied to clipboard

[tests] Enable _test_csv_mappings

Open snack0verflow opened this issue 5 years ago • 5 comments

While trying to increase code coverage of ELK tests I found that the following routine has been disabled: https://github.com/chaoss/grimoirelab-elk/blob/master/tests/base.py#L197 I tried enabling in but I ran into this problem:

File "/home/abid/sources/grimoirelab-elk/tests/base.py", line 205, in _test_csv_mappings
    csv_mapping = load_mapping(self.enrich_index, self.connector)
  File "/home/abid/sources/grimoirelab-elk/tests/base.py", line 49, in load_mapping
    cvs_mapping = ESMapping.from_csv(enrich_index, cvs_path)
  File "../tests/model.py", line 184, in from_csv
    with open(csv_file) as f:
FileNotFoundError: [Errno 2] No such file or directory: '../schema/github.csv'

Apparently we have a different schema for various github things like PRs and issues. Can anything be done to enable this routine? @valeriocos

snack0verflow avatar Mar 08 '20 16:03 snack0verflow

Ideally, the enriched indexes should be checked against the schemas, that code was prepared time ago (https://github.com/chaoss/grimoirelab-elk/commit/523f044b8d75c717fbc67fb344988fbefc6a1365), but the schemas haven't been updated so far.

If you are up for this task, we can work together. We could evaluate which schemas should be updated and split the work in different PRs (since it's a long task :)). WDYT?

valeriocos avatar Mar 08 '20 17:03 valeriocos

@valeriocos seems like we can work on this. We can discuss on IRC tomorrow?

snack0verflow avatar Mar 08 '20 19:03 snack0verflow

sure @snack0verflow ! I'll ping you here as soon as i'm on IRC

valeriocos avatar Mar 08 '20 19:03 valeriocos

Hi @snack0verflow I'll be connected to IRC today from 14h to 17h (Madrid time)

valeriocos avatar Mar 09 '20 09:03 valeriocos

@valeriocos pinged you

snack0verflow avatar Mar 09 '20 13:03 snack0verflow

Closing this because there's no activity on this issue and looks like old code.

jjmerchante avatar Oct 11 '23 15:10 jjmerchante