Replace hardcoded list of Maniphest open statūs by querying actual config of Phorge

[aklapper]

From /elk/phabricator.py:

if eitem['status'] not in [TASK_OPEN_STATUS, 'Spite', 'Stalled']:

Hardcoding values here looks brittle (and error-prone if some customizations have taken place).

Conduit's maniphest.querystatuses API call offers the values of maniphest.statuses in the global Phabricator config, listed under openStatuses. You may want to consider this. :)

[jjmerchante]

We will keep the statuses hardcoded in a list to avoid creating new calls to the API.

Thank you for your proposal.

[aklapper]

@jjmerchante Could you elaborate why one (1) single additional API call to pull the statuses (and cache them in Grimoirelab) is problematic?

The current situation means (for our installation with customized statuses) that data will be incomplete and thus useless.

[sduenas]

@aklapper how long do you will use phabricator still? we have plans to drops the support of this backend since phabricator support and development stopped. I know you in wikimedia have a plan to replace it but not sure about the timeline.

[aklapper]

@sduenas: https://we.phorge.it/ (a fork of stopped Phabricator) is quite alive; Wikimedia has no plan to replace its use of Phorge. The backend should likely be renamed from "Phabricator" to "Phorge" in my opinion.

[sduenas]

I didn't know about that. We definitely should rename it. I'll open a ticket in grimoirelab repository.

[sduenas]

Ticket opened: https://github.com/chaoss/grimoirelab/issues/614