chaoss
re-check handling of ResourceGoneException when issues are disabled
I introduced a ResourceGoneException for when augur tries to query issues when a repo has them disabled
It seems like this may not being handled.
I think you are saying that this exception is not getting triggered where you expect?
no, the exception is getting thrown as intended, im just filing this as a note because i (or someone else) should probably check that it is being caught and handled, because currently it seems to be causing a collection task to fail, causing that phase of collection (core probably) to fail, and therefore holding up everything else.
This "fail the task" may be intentional in the scope of "if we are in a collect issues task, we should fail/not do the task if issues are disabled" but i think i did not anticipate the cascading nature of celery tasks thats turning this into "issues disabled -> dont collect anything for this entire repo"
best case i just need to change the specific celery exception that im converting this one to when it hits the celery layer of the stack (i.e. tell it to skip the task rather than fail)
worst case, this could be a really complicated fix
ResourceGoneException is one that I created/named myself within augur, so it should be easy to search the codebase for and see how it is used (its really quite simple)
ResourceGoneException is one that I created/named myself within augur, so it should be easy to search the codebase for and see how it is used (its really quite simple)
This is incorrect, the exception I created is RepoGoneException and that has yet to be merged (#3391)