chaoss
Fix: String to Date #2662
Description
This PR converts current_release_date and latest_release_date from string type to Date format.
This PR fixes #2663
Notes for Reviewers
Signed commits
- [x] Yes, I signed my commits.
@MoralCode are you working on this now? or I can continue? as I got to know that now changes need new files and this is 35th and I will update- remove the suggestions and update accordingly.
This change is going to require more than just a schema change. We discussed it briefly at the end of today's Augur call and Sean mentioned that this is likely to require a fair degree of logic changes as well, especially to make sure that various error cases get handled when converting date values (which come from various sources and may all be in different formats).
Also since this is a breaking schema change, I think its going to get through review faster if an existing maintainer can handle it.
I can't stop you from working on it, but i will likely be adopting this change and working with the maintainers to figure out the best way to handle it (along with lots of other database changes) - especially given similar/related issues like #1370
This change is going to require more than just a schema change. We discussed it briefly at the end of today's Augur call and Sean mentioned that this is likely to require a fair degree of logic changes as well, especially to make sure that various error cases get handled when converting date values (which come from various sources and may all be in different formats).
Also since this is a breaking schema change, I think its going to get through review faster if an existing maintainer can handle it.
I can't stop you from working on it, but i will likely be adopting this change and working with the maintainers to figure out the best way to handle it (along with lots of other database changes) - especially given similar/related issues like #1370
Ok. got your point will work on this so that can understand database system in the augur deeply and manage to solve other issues related to database.
@MoralCode : We probably should discuss this one and decide how it intersects with the other db updates you've been working on.
We probably should discuss this one and decide how it intersects with the other db updates you've been working on.
This is a pretty major fix, possibly a breaking change that is very likely to require some soecial handling/special consideration for how to migrate existing data, which can be in just about any date format. I dont really know how to resolve this cleanly and its probably going to be a pretty big effort that may not be worth it for a while.
Closing this PR as I dont see it getting merged anytime soon due to the aforementioned complexities surrounding handling peoples existing data from Augur instances of various ages