chaoss
Remove potentially legacy working commits call/table
https://github.com/chaoss/augur/blob/c5eeb072ae5c541e5fbb56295b3afab5dffaf4b0/augur/tasks/git/facade_tasks.py#L335C5-L335C49
this line prompted a disussion with @IsaacMilarky
It seems like this line is from legacy facade where it would collect into a working_commits table (so it could pick up a partial collection where it left off) and then at the end it would transfer them to the commits table.
As far as i can see, analyze_commits_in_parallel calls this https://github.com/chaoss/augur/blob/c5eeb072ae5c541e5fbb56295b3afab5dffaf4b0/augur/application/db/lib.py#L212
which uses the ORM Commit object https://github.com/chaoss/augur/blob/main/augur/application/db/models/augur_data.py#L1261
to write directly to the commits table
so this may need to be removed along with the table it refers to (although maybe an audit is necessary)
working_commits only referenced in facade_tasks.py, db/lib.py, model definitions, and old facade_worker files.
What we can do :
- Remove calls and helper functions using
working_commits - Drop its table definitions from models
- add migration to drop the table (Optional though)
I would like to pick this issue !
working_commits only referenced in facade_tasks.py, db/lib.py, model definitions, and old facade_worker files.
I think it would be helpful to start with just analyzing - i.e. can we get a list together of all the places this table is used, and possibly also run augur and have it collect on some repositories while keeping an eye on that table to see if its ever actually being used?
Because this is removing a bunch of legacy code, I'd want to be careful about how we do it because i want to make sure the code is actually no longer in use
Im thinking the process could look like
- analyze per the above
- comment out all the uses of the table and see if that changes augur's behavior/affects how it runs/collects stuff
- remove the code and create the migration to drop the table