augur icon indicating copy to clipboard operation
augur copied to clipboard

Remove unused weight-based method of scheduling

Open MoralCode opened this issue 3 months ago • 3 comments

Per a recent meeting among several core augur maintainers, it sounds like there is a legacy method of scheduing tasks that involved calculating a weight and assigning it to each task.

It was mentioned by @IsaacMilarky that this is no longer used.

I think we should consider removing this old scheduling method (or at least commenting out the code and removing the DB columns.

This would mean removing all columns with names suffixed with _weight from the collection status table of the augur_operations database.

MoralCode avatar Sep 10 '25 19:09 MoralCode

It may also be worth documenting this method of scheduling in what could become a new "history" section of the ReadTheDocs page so that contributors can understand how things are the way they are by looking at eays we used to do things that turned out to eventually be replaced

MoralCode avatar Sep 10 '25 19:09 MoralCode

this is probably part of this system and should be removed too: https://github.com/chaoss/augur/blob/2c9a5f1f2a9b58cfec035982fd0b27bd31cb0fbe/augur/tasks/git/facade_tasks.py#L404

MoralCode avatar Sep 16 '25 03:09 MoralCode

The task that updates these weights was commented out in https://github.com/chaoss/augur/pull/2987

update_facade_scheduling_fields may need more precise handling though since it updates the commit_sum field that still maybe in use given queries in https://github.com/chaoss/augur/issues/3319#issuecomment-3530007760 which compare against it to check facade's status

MoralCode avatar Dec 01 '25 20:12 MoralCode