augur icon indicating copy to clipboard operation
augur copied to clipboard

Database container port inconsistency

Open mhauru opened this issue 10 months ago • 1 comments

The main Makefile and a couple of pages in the documentation assume that the database Docker container is run so that the PostgreSQL port is 5434: https://github.com/search?q=repo%3Achaoss%2Faugur%205434&type=code

However, some other places use the default port 5432. Here are a few files doing that, I'm not sure I found all of the cases: https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/scripts/control/refresh-matviews.sh https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/docs/new-install.md https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/docker-compose.yml#L13 https://github.com/chaoss/augur/blob/a786ac5a506ffac31931f40c2a58056b7c1f073c/augur/application/cli/db.py#L323

mhauru avatar Apr 24 '24 15:04 mhauru

I think this is an artifact of times gone by -- augur_database is not the same as the postgres container recently included in the compose file.

some of the blame shows this was done literally 4 years ago -- maybe the project has pivoted since then

GaryPWhite avatar May 02 '24 14:05 GaryPWhite

@ABrain7710 : Can you look into this?

sgoggins avatar May 14 '24 16:05 sgoggins