augur icon indicating copy to clipboard operation
augur copied to clipboard

We should use Timestamp With Time Zone

Open jberkus opened this issue 3 years ago • 5 comments

Currently all timestamps in the database are TIMESTAMP WITHOUT TIME ZONE. This prevents the user from easily querying the database in their own local time zone, which leads to confusion when the user compares the timestamp they see in the Github/lab UI with the timestamp they see in the database. Further, it may be causing data issues if the GH API and the GL API are not using the same timezone (are they?).

We should figure out what time zone each of github and gitlab are using, and store them as TIMESTAMPTZ.

jberkus avatar Jul 22 '21 00:07 jberkus

There are timestamps with timezones on the commit table. We can make this a standard as well.

sgoggins avatar Jul 22 '21 13:07 sgoggins

This commits table is possible because we analyze commits doing the gitlog ... surely something similar is possible with the API's

sgoggins avatar Jul 22 '21 13:07 sgoggins

For GH: https://developer.github.com/changes/26/

jberkus avatar Jul 22 '21 16:07 jberkus

OK ... that's a very nice update to the GitHub API since we first started working with Augur!

sgoggins avatar Aug 10 '21 17:08 sgoggins

@sgoggins does this still need solving?

kaxada avatar Oct 30 '23 13:10 kaxada